Fix docks disappearing in NAV when >100% UI scale #2898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The occlusion bounds in the dock drawing code didn't take into account UI scale, so docks passed a certain point would disappear. Fixes new-frontiers-14#2775
whatston3
reviewed
Feb 10, 2025
dvir001
approved these changes
Feb 11, 2025
FrontierATC
added a commit
that referenced
this pull request
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2775
About the PR
The occlusion bounds in the dock drawing code didn't take into account UI scale, so docks passed a certain point would disappear. This patch fixes the issue.
Why / Balance
Not being able to see docks too far to the right/bottom of the view is annoying. So is playing at 100% UI scale on a high-DPI display.
How to test
Media
Before:
After:
Requirements
Breaking changes
Changelog
🆑